Skip to content

use multiapi instead of all-api-versions #1148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
leniatgh wants to merge 4 commits into from
Closed

use multiapi instead of all-api-versions #1148

leniatgh wants to merge 4 commits into from

Conversation

@leniatgh
Copy link
Contributor

@leniatgh leniatgh commented Aug 27, 2020

This PR is to align the autorest parameters with the one used in SDK Automation pipeline, i.e., use --multiapi instead of --all-api-versions. With --multiapi parameter, autorest reads the tags in readme.azureresourceschema.md, and generate schemas for each tag.

@anthony-c-martin
Copy link
Member

anthony-c-martin commented Aug 27, 2020

@leni-msft your changes look good to me. Have you validated that they generate exactly the same set of schemas when you run npm run generate-all?

@leniatgh
Copy link
Contributor Author

leniatgh commented Aug 27, 2020

@anthony-c-martin I tried generate-single for several onboarded RPs, and the result are same. I will try generate-all, and update you further. Stay tuned. :)

@anthony-c-martin
Copy link
Member

anthony-c-martin commented Aug 27, 2020

@anthony-c-martin I tried generate-single for several onboarded RPs, and the result are same. I will try generate-all, and update you further. Stay tuned. :)

Thanks! You can probably also just kick off the pipelines here on this branch to check this.

@leniatgh
Copy link
Contributor Author

leniatgh commented Aug 29, 2020

@anthony-c-martin Thanks for the information. The pipeline executed successfully. Here's draft PR to see the schema changes: https://github.com/Azure/azure-resource-manager-schemas/pull/1156/files/87abca78f5ab4d04f67d584885d7885f7ad5ddc2..97861662d0be9845d192c086f97755c26705680e I'll continue investigate the cause.

@leniatgh leniatgh closed this Aug 31, 2020
@leniatgh leniatgh mentioned this pull request Aug 31, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anthony-c-martin anthony-c-martin Awaiting requested review from anthony-c-martin

@azcloudfarmer azcloudfarmer Awaiting requested review from azcloudfarmer

@jorgecotillo jorgecotillo Awaiting requested review from jorgecotillo

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@leniatgh @anthony-c-martin